@julian The readme.md file at the root of the fork (the one displayed at the bottom of https://github.com/rudeog/LXR ) has all the major points. As to your concern about the midi note name stuff, the one thing we could do is re-purpose the "midi mode" (which was previously note or trigger) to select whether to display note names vs values (as it used to display). I could do that fix if you think it's worth it. Let me know what midi fixes you are going to work on, as I had some that I was going to do and don't want to end up doing the same thing. I need to fix the midi note-off to send note off when the pattern changes (so you don't get stuck notes) and also when muting a voice, or changing other stuff. I was also thinking of taking a stab at sending and recognizing program change messages to affect (or be affected by) the current pattern number.
@ceasless The problem with the base coarse value is that it is very much influenced by the pitch mod. A while ago I ran it thru a tuner, and it was a bit of a beard-scratcher for me.
Since I can't reproduce the remaining sync issue reported in a post regarding ableton USB sync, and you already fixed the other sync issues (midi continue) I would work on other stuff from my buglist.
I'm happy if you want to take a look at program changes and the midi off issues (I also noticed the missing note off when muting). I think I will first check out the pitch modulation bug. The basic coarse tuning should not be effected by the envelope.
Would you be interested in a free trigger IO for all your work?
I'd love a trigger IO! That sounds cool! I will continue to work on the midi issues.
Yes, my main reason for the notes was for sequencing external gear.
Having the coarse parameter display note names instead of a value makes sense if the sound it plays is actually that note (I guess assuming no pitch mod has been applied).
One idea I'm thinking: Midi mode is re-purposed to be one of 4 states, "absolute", "relative", "fixed" or "off":
absolute: The midi note in the sequencer step is sent as it's displayed (the way it works now). The coarse pitch setting (which we can change to a note display) only affects the pitch of the internal sound engine, and the sequencer note values are still added or subtracted from that for the purpose of the internal sound engine.
relative: The coarse note setting represents the root note. The sequencer note display changes to -63 to +63 and affects the note sent on midi to be the coarse note added/subtracted to/from that value. The internal sound engine still behaves the same. This could also be cool for sequencing in a way, eg you could set your key to "C3" (on the coarse parameter) and then set the notes to be offset from that, then change keys (transpose) by simply changing the Coarse parameter. I think one of the members mentioned wanting a transpose ability.
fixed: The coarse note setting is always sent on midi regardless of the sequencer notes. Their display changes to -63 to +63 but will only affect the internal engine. This is more useful for someone trying to sequence another drum machine where the notes that trigger the drum sounds are already set in stone on that drum machine. (this is equivalent to our old midi trg(?) mode but gives the flexibility of changing the note value for a drum sound)
off: no midi is sent/received for the voice and both coarse and sequencer steps show a numeric value
Using the above, we could get rid of the new "midi note" setting (Which although flexible, might be less than intuitive), and bring back the midi mode setting which can be one of the 4 states.
The only issue with the above scheme is that in "absolute" mode, the coarse note setting will have no bearing on what is sent via midi, which may cause some mild confusion among some. Also, the note names on the sequencer will not have any relation to the internal engine sound (as they are still offsets from coarse).
Yeah, thank you for doing this discussion in the forum!
I think it is a nice idea to define a basic pitch like "C1" by the coarse parameter. The note parameter of the sequencer could be a relative value between -63 and +63 (so +/- 5 octaves). The midi note that is send could be defined by the coarse value added with the note parameter. This would also allow you to transpose a pattern by tweaking the coarse parameter or define a note for a drum sound with the note value set to 0 for all steps. I think it makes no sense to differentiate between internal and external notes. I would suggest to keep it as simple as possible.
Comments
@ceasless The problem with the base coarse value is that it is very much influenced by the pitch mod. A while ago I ran it thru a tuner, and it was a bit of a beard-scratcher for me.
I'm happy if you want to take a look at program changes and the midi off issues (I also noticed the missing note off when muting). I think I will first check out the pitch modulation bug. The basic coarse tuning should not be effected by the envelope.
Would you be interested in a free trigger IO for all your work?
Yes, my main reason for the notes was for sequencing external gear.
Having the coarse parameter display note names instead of a value makes sense if the sound it plays is actually that note (I guess assuming no pitch mod has been applied).
One idea I'm thinking: Midi mode is re-purposed to be one of 4 states, "absolute", "relative", "fixed" or "off":
absolute: The midi note in the sequencer step is sent as it's displayed (the way it works now). The coarse pitch setting (which we can change to a note display) only affects the pitch of the internal sound engine, and the sequencer note values are still added or subtracted from that for the purpose of the internal sound engine.
relative: The coarse note setting represents the root note. The sequencer note display changes to -63 to +63 and affects the note sent on midi to be the coarse note added/subtracted to/from that value. The internal sound engine still behaves the same. This could also be cool for sequencing in a way, eg you could set your key to "C3" (on the coarse parameter) and then set the notes to be offset from that, then change keys (transpose) by simply changing the Coarse parameter. I think one of the members mentioned wanting a transpose ability.
fixed: The coarse note setting is always sent on midi regardless of the sequencer notes. Their display changes to -63 to +63 but will only affect the internal engine. This is more useful for someone trying to sequence another drum machine where the notes that trigger the drum sounds are already set in stone on that drum machine. (this is equivalent to our old midi trg(?) mode but gives the flexibility of changing the note value for a drum sound)
off: no midi is sent/received for the voice and both coarse and sequencer steps show a numeric value
Using the above, we could get rid of the new "midi note" setting (Which although flexible, might be less than intuitive), and bring back the midi mode setting which can be one of the 4 states.
The only issue with the above scheme is that in "absolute" mode, the coarse note setting will have no bearing on what is sent via midi, which may cause some mild confusion among some. Also, the note names on the sequencer will not have any relation to the internal engine sound (as they are still offsets from coarse).
Just some ideas.
Thanks.
I think it is a nice idea to define a basic pitch like "C1" by the
coarse parameter. The note parameter of the sequencer could be a relative
value between -63 and +63 (so +/- 5 octaves).
The midi note that is send could be defined by the coarse value added with the note parameter.
This would also allow you to transpose a pattern by tweaking the coarse parameter or define a note for a drum sound with the note value set to 0 for all steps.
I think it makes no sense to differentiate between internal and external notes.
I would suggest to keep it as simple as possible.
yea i would def like seeing note names instead of #'s.
does like a Coarse Tune of 0 = C0? or whats the pitch number to pitch note correlation?